Skip to content

Visualisation example#2

Open
tinaok wants to merge 13 commits into
xdggs:mainfrom
tinaok:main
Open

Visualisation example#2
tinaok wants to merge 13 commits into
xdggs:mainfrom
tinaok:main

Conversation

@tinaok

@tinaok tinaok commented Oct 8, 2024

Copy link
Copy Markdown

No description provided.

@tinaok

tinaok commented Nov 26, 2024

Copy link
Copy Markdown
Author

@annefou I want to merge this commit, is this error from pre-commit, something we can ignore?

@annefou

annefou commented Nov 26, 2024

Copy link
Copy Markdown

No, I can fix it. Can you add me as collaborator to https://github.com/tinaok/xdggs_examples ?

@tinaok

tinaok commented Nov 26, 2024

Copy link
Copy Markdown
Author

I'm a member, so I can't I think @keewis can.

@annefou

annefou commented Nov 26, 2024 via email

Copy link
Copy Markdown

@tinaok

tinaok commented Nov 26, 2024

Copy link
Copy Markdown
Author

Thank you anne!

@annefou

annefou commented Nov 26, 2024

Copy link
Copy Markdown

Do you want to merge it?

@keewis keewis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the install instructions in the notebook are out-of-date, this should be just pip install xdggs now.

Comment thread .pre-commit-config.yaml Outdated
Comment thread .pre-commit-config.yaml Outdated
annefou and others added 2 commits November 26, 2024 14:04
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
@annefou

annefou commented Nov 26, 2024

Copy link
Copy Markdown

the install instructions in the notebook are out-of-date, this should be just pip install xdggs now.

Should we also pin the version?

@keewis

keewis commented Nov 26, 2024

Copy link
Copy Markdown
Member

not sure. I don't think the interface will change as drastically as between 0.0.1 and 0.1.0, but if you want to be absolutely sure you can pin it to 0.1

and make directly install from pypi
@annefou

annefou commented Nov 26, 2024

Copy link
Copy Markdown

I would suggest we add xdggs in the condo environment and then remove it from the jupyter notebook. What do you think? @tinaok @keewis

@tinaok

tinaok commented Nov 26, 2024

Copy link
Copy Markdown
Author

I think it only works with pip (and not with condo) for xdggs today

@annefou

annefou commented Nov 26, 2024

Copy link
Copy Markdown

Yes. But we could add it in the pip section of .binder/environment.yml?

@tinaok

tinaok commented Nov 26, 2024

Copy link
Copy Markdown
Author

yes

and explain the two different ways to get xdggs e.g. with pip only or using the environment.yml file from .binder folder
@tinaok

tinaok commented Dec 8, 2024

Copy link
Copy Markdown
Author

@keewis can we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants